Skip to content

refactor(agent): improve drupal hook map error logging #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2025
Merged

refactor(agent): improve drupal hook map error logging #1101

merged 3 commits into from
Aug 5, 2025

Conversation

bduranleau-nr
Copy link
Contributor

@bduranleau-nr bduranleau-nr commented Jul 11, 2025 •
edited
Loading

Addresses #1099
Enhances #1100

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Jul 11, 2025 •
edited
Loading

Test Suite Status Result
Multiverse ✅ 16/16 passing
SOAK ✅ 85/85 passing

zsistla
zsistla reviewed Jul 11, 2025
View reviewed changes
zsistla
zsistla reviewed Jul 11, 2025
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.12%. Comparing base (f58a459) to head (b3531f5).

Files with missing lines Patch % Lines
agent/fw_drupal8.c 75.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1101      +/-   ##
==========================================
- Coverage   78.13%   78.12%   -0.02%     
==========================================
  Files         193      193              
  Lines       27976    27979       +3     
==========================================
- Hits        21859    21858       -1     
- Misses       6117     6121       +4
Flag Coverage Δ
agent-for-php-7.2 78.37% <0.00%> (-0.01%) ⬇️
agent-for-php-7.3 78.38% <0.00%> (-0.01%) ⬇️
agent-for-php-7.4 78.24% <90.00%> (-0.01%) ⬇️
agent-for-php-8.0 77.45% <90.00%> (-0.01%) ⬇️
agent-for-php-8.1 77.76% <90.00%> (-0.01%) ⬇️
agent-for-php-8.2 77.38% <90.00%> (-0.01%) ⬇️
agent-for-php-8.3 77.38% <90.00%> (-0.01%) ⬇️
agent-for-php-8.4 77.40% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zsistla
zsistla reviewed Jul 11, 2025
View reviewed changes
@bduranleau-nr bduranleau-nr marked this pull request as ready for review July 11, 2025 20:42
@bduranleau-nr bduranleau-nr mentioned this pull request Jul 11, 2025
Closed
@lavarou lavarou added this to the next-release milestone Jul 14, 2025
@bduranleau-nr bduranleau-nr merged commit c395102 into dev Aug 5, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZNeumann ZNeumann ZNeumann approved these changes

@zsistla zsistla zsistla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@bduranleau-nr @newrelic-php-agent-bot @codecov-commenter @ZNeumann @zsistla @lavarou